Thread (31 messages) 31 messages, 5 authors, 2021-07-10

Re: [PATCH RFC v2] m68k: remove get_fs()/set_fs()

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2021-07-09 21:19:09

On Fri, Jul 9, 2021 at 2:08 PM Michael Schmitz [off-list ref] wrote:
The 8 byte copies are by far the majority.
llseek might actually not be unusual. And the timeval structure is - I
think - 8 bytes on 32-bit architectures and common for select timeouts
etc. And select/poll can be one of the most common system calls out
there depending on loads (usually graphical programs).

But again - I don't think it's even worth worrying about in
architecture code. If you actually can measure it, I think we should
fix it in generic code rather than have architectures work around some
issue one by one.

I think the main issue for m68k should be "is it stable and works". At
least first. And then worry about copy_to/from_user() with a constant
size as a very very distant second concern.

              Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help