Re: [PATCH RFC v2] m68k: remove get_fs()/set_fs()

Am 10.07.2021 um 07:25 schrieb Michael Schmitz:

Hi Geert,

Am 09.07.2021 um 23:20 schrieb Geert Uytterhoeven:

quoted

Hi Michael,

On Fri, Jul 9, 2021 at 11:00 AM Michael Schmitz [off-list ref]
wrote:

quoted

Am 09.07.2021 um 20:53 schrieb Christoph Hellwig:

quoted

On Fri, Jul 09, 2021 at 08:34:07PM +1200, Michael Schmitz wrote:

quoted

Just booting to a login prompt: Quite a few with 8 bytes, some with
4 bytes
(those from the keyboard driver), the rest is 16, 24, 36 and 92
bytes (a

Over 400x 8 bytes, 20x 4 bytes on a count with the larger one
suppressed.

quoted

The 4/8 byte ones can usually be switched to just use get/put_user
easily.

Need to log the call sites then ... that should be fun. Something to do
tomorrow :-)

WARN_ON_ONCE() is your friend.

Sure - here's the result:

WARNING: CPU: 0 PID: 1 at ./arch/m68k/include/asm/uaccess.h:395
raw_copy_to_user.constprop.27+0x26/0x42

That one got called from sys_llseek+0x5c/0x86

Cheers,

	Michael

WARNING: CPU: 0 PID: 819 at ./arch/m68k/include/asm/uaccess.h:395
do_pipe2+0x4a/0xbc
WARNING: CPU: 0 PID: 838 at ./arch/m68k/include/asm/uaccess.h:395
__put_old_timespec32+0x36/0x58
WARNING: CPU: 0 PID: 854 at ./arch/m68k/include/asm/uaccess.h:303
vt_do_kdsk_ioctl+0x38/0x28a
WARNING: CPU: 0 PID: 950 at ./arch/m68k/include/asm/uaccess.h:395
tty_ioctl+0x27a/0x6c4

uaccess.h:303 is __constant_copy_from_user.

Cheers,

    Michael

quoted

Gr{oetje,eeting}s,

                        Geert