On Fri, Nov 26, 2021 at 07:12:03PM +0100, Henning Schild wrote:

Am Fri, 26 Nov 2021 17:02:00 +0200
schrieb Andy Shevchenko [off-list ref]:

quoted

On Fri, Nov 26, 2021 at 4:10 PM Henning Schild
[off-list ref] wrote:

quoted

This driver adds initial support for several devices from Siemens.
It is based on a platform driver introduced in an earlier commit.  

...

quoted

+static struct simatic_ipc_led simatic_ipc_leds_mem[] = {
+       {0x500 + 0x1A0, "red:" LED_FUNCTION_STATUS "-1"},
+       {0x500 + 0x1A8, "green:" LED_FUNCTION_STATUS "-1"},
+       {0x500 + 0x1C8, "red:" LED_FUNCTION_STATUS "-2"},
+       {0x500 + 0x1D0, "green:" LED_FUNCTION_STATUS "-2"},
+       {0x500 + 0x1E0, "red:" LED_FUNCTION_STATUS "-3"},
+       {0x500 + 0x198, "green:" LED_FUNCTION_STATUS "-3"},
+       { }
+};  

Like I said, this is not okay.

Why can't you simply enable the pinctrl driver and use it?

I have talked to my boss today and I have got an approval to prioritize
the task, so I'm all yours starting from tomorrow.

Let's finish it once for all!

I propose we set up a call, that might help clearing up the situation.
If you agree please send me an email and possibly propose a time-slot.
I would take it from there and send you a meeting link.

Sure!

-- 
With Best Regards,
Andy Shevchenko