Thread (16 messages) 16 messages, 3 authors, 2021-12-03

Re: [PATCH v4 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

From: Henning Schild <hidden>
Date: 2021-11-26 17:51:00
Also in: linux-watchdog, lkml, platform-driver-x86

Am Fri, 26 Nov 2021 17:02:00 +0200
schrieb Andy Shevchenko [off-list ref]:
On Fri, Nov 26, 2021 at 4:10 PM Henning Schild
[off-list ref] wrote:
quoted
This driver adds initial support for several devices from Siemens.
It is based on a platform driver introduced in an earlier commit.  
...
quoted
+static struct simatic_ipc_led simatic_ipc_leds_mem[] = {
+       {0x500 + 0x1A0, "red:" LED_FUNCTION_STATUS "-1"},
+       {0x500 + 0x1A8, "green:" LED_FUNCTION_STATUS "-1"},
+       {0x500 + 0x1C8, "red:" LED_FUNCTION_STATUS "-2"},
+       {0x500 + 0x1D0, "green:" LED_FUNCTION_STATUS "-2"},
+       {0x500 + 0x1E0, "red:" LED_FUNCTION_STATUS "-3"},
+       {0x500 + 0x198, "green:" LED_FUNCTION_STATUS "-3"},
+       { }
+};  
Like I said, this is not okay.

Why can't you simply enable the pinctrl driver and use it?
What do you mean with enable (=m, =y)? The kernel has it built in ...
but it does not come up because it does not find an ACPI table entry
nor a p2sb PCI device.

When with enable you mean ... repair the pinctrl drivers with your
patches, i am afraid i am not qualified and hardly responsible. It is
not "simple" for me. I will test and switch to pinctrl .... but here i
am tired of waiting and pushing/asking to turn the order of patches
around.

Or can i trigger the pinctrl driver to probe from my init/probe?

Henning
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help