Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change
From: David Miller <davem@davemloft.net>
Date: 2016-10-13 14:46:42
Also in:
lkml, netdev
From: Zach Brown <redacted> Date: Tue, 11 Oct 2016 15:26:20 -0500
From: Josh Cartwright <redacted> Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a set of led triggers for each instantiated PHY device. There is one LED trigger per link-speed, per-phy. This allows for a user to configure their system to allow a set of LEDs to represent link state changes on the phy. Signed-off-by: Josh Cartwright <redacted> Signed-off-by: Nathan Sullivan <redacted> Signed-off-by: Zach Brown <redacted>
...
quoted hunk ↗ jump to hunk
+ static const char * const name_suffix[] = { + "10Mbps", + "100Mbps", + "1Gbps", + "2.5Gbps", + "10Gbps",
This choice of both the array size and the speeds to support seems entirely arbitrary and is inappropriate for a generic driver of this kind. This seems to be hard coding this to support the list of speeds supported by whatever driver you want to use with this new LED facility, and sorry that's not how we build nice generic pieces of infrastructure. Thanks.