On Wed, Aug 4, 2021 at 9:12 PM Utkarsh Verma [off-list ref] wrote:

On Tue, Aug 03, 2021 at 08:11:28PM +0200, Lukas Bulwahn wrote:

quoted

On Tue, Aug 3, 2021 at 4:21 PM Utkarsh Verma [off-list ref] wrote:

quoted

This fixed the below checkpatch issue:

Use imperative; you can drop "below" here.

quoted

WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.

Signed-off-by: Utkarsh Verma <redacted>
Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Usually it is Suggested-by first, then Signed-off-by at the end.

Do you find a pointer for this order of tags on the commit message in
the documentation, e.g., in
Documentation/process/submitting-patches.rst?

No, I didn't found any such rule in the Documentation files.

I think you could try to create a patch to add that information on the
ordering of these tags here:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

You will find the source of that documentation at
Documentation/process/submitting-patches.rst.

Do you want to give that a quick try?

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees