Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig'

On 11.8.2011 10:42, David Woodhouse wrote:

On Wed, 2011-08-10 at 23:29 -0400, Arnaud Lacombe wrote:

quoted

how is that supposed to work with your other patches ?

You cannot perform build targets with CONFIG symbols overridden.

quoted

% make CONFIG_NET=y allyesconfig drivers/ata/ 

        ^^^^^^^ override           ^^^^^^^^^^ build target

quoted

Makefile:504: *** Cannot perform build targets with CONFIG symbols
overridden.  Stop.

 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error message which
told you that, if you'd been paying the slightest bit of attention
rather than just making pointless noise.

I would much rather see include/config/auto.conf reset all configuration
variables to match what kconfig computed. I.e. use 'undefine CONFIG_FOO'
instead of '# CONFIG_FOO is not set'. Additionally print this for any
CONFIG_* variable found in the environment, even if the symbol is not
visible in the current configuration. The include/config/auto.conf file
is only used internally, so it should be safe to change the format.

Michal