Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig'
From: David Woodhouse <dwmw2@infradead.org>
Date: 2011-08-10 23:17:32
Also in:
lkml
Subsystem:
kernel build + files below scripts/ (unless maintained elsewhere), the rest · Maintainers:
Nathan Chancellor, Nicolas Schier, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2011-08-11 · Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' · David Woodhouse <dwmw2@infradead.org>
- 2011-08-11 · Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' · Michal Marek <hidden>
- 2011-08-11 · Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' · David Woodhouse <dwmw2@infradead.org>
- 2011-08-11 · Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' · Arnaud Lacombe <hidden>
- 2011-08-11 · Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' · David Woodhouse <dwmw2@infradead.org>
On Wed, 2011-08-10 at 18:33 -0400, Arnaud Lacombe wrote:
quoted
We're not enabling anything that we're later going to break. I can't see many people *depending* on the fact that 'make CONFIG_SATA_MV=y oldconfig' actually does *nothing* in some cases.you are wrong, you ends up with half-baked compile-time dependency, which break the build:
s/*nothing*/nothing useful/, for crying out loud. The point remains that we're not enabling anything which we're later going to break. Nobody is going to come to *depend* on this behaviour. And anyway, this behaviour exists even *before* my patches, as Michal pointed out in a far more helpful and constructive fashion in [ref] earlier today. It's simple enough to fix, too:
diff --git a/Makefile b/Makefile
index 1fc5172..6cc7f7b 100644
--- a/Makefile
+++ b/Makefile@@ -474,6 +474,9 @@ ifeq ($(KBUILD_EXTMOD),) endif endif +# This could probably be simpler? +CONFIG_OVERRIDES := $(patsubst line:%,%,$(filter line:%,$(foreach var, $(filter CONFIG_%,$(.VARIABLES)), $(origin $(var)):$(var)))) + ifeq ($(mixed-targets),1) # =========================================================================== # We're called with mixed targets (*config and build targets).
@@ -507,6 +510,10 @@ else # Build targets only - this includes vmlinux, arch specific targets, clean # targets and others. In general all targets except *config targets. +ifneq ($(CONFIG_OVERRIDES),) +$(error Cannot perform build targets with CONFIG symbols overridden) +endif + ifeq ($(KBUILD_EXTMOD),) # Additional helpers built in scripts/ # Carefully list dependencies so we do not try to build scripts twice
--
dwmw2