Re: [PATCH 131/141] tpm: Fix fall-through warnings for Clang

On Tue, Nov 24, 2020 at 12:53:22AM +0200, Jarkko Sakkinen wrote:

On Tue, Nov 24, 2020 at 12:52:31AM +0200, Jarkko Sakkinen wrote:

quoted

On Fri, Nov 20, 2020 at 12:40:14PM -0600, Gustavo A. R. Silva wrote:

quoted

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/char/tpm/eventlog/tpm1.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
index 2c96977ad080..8aa9057601d6 100644
--- a/drivers/char/tpm/eventlog/tpm1.c
+++ b/drivers/char/tpm/eventlog/tpm1.c

@@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event,
 		default:
 			break;
 		}
+		break;
 	default:
 		break;
 	}

-- 
2.27.0

Reviewed-by: Jarkko Sakkinen <redacted>

Who is picking these patches?

I can take it in my tree for 5.11 if people are OK with that. :)

quoted

/Jarkko

I mean

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

Thanks, Jarkko.
--
Gustavo