Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The new compatible strings are defined as standalone enums without a generic fallback, causing drivers to fail to probe.
- [Low] The commit message description starts with a lowercase letter, violating MFD subsystem guidelines.
--
--- Patch [4]: [PATCH v7 4/6] dt-bindings: mfd: motorola-cpcap: document Mapphone and Mot CPCAP ---
commit d9f93935d00aa3510052461fef588d4ce3014eed
Author: Svyatoslav Ryhel [off-list ref]
dt-bindings: mfd: motorola-cpcap: document Mapphone and Mot CPCAP
Add compatibles for Mapphone and Mot CPCAP subdevice compositions. Both
variations cannot use st,6556002 fallback since they may be based on
different controllers.
dt-bindings: mfd: motorola-cpcap: document Mapphone and Mot CPCAP
[Severity: Low]
This isn't a bug, but should the description part of the commit message be
capitalized? The MFD subsystem guidelines typically expect a capitalized
description after the subsystem prefix.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml b/Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
index 76705ea56805a..da7abe2ec9126 100644
--- a/Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
+++ b/Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml
@@ -14,9 +14,14 @@ allOf:
properties:
compatible:
- items:
- - const: motorola,cpcap
- - const: st,6556002
+ oneOf:
+ - enum:
+ - motorola,mapphone-cpcap
+ - motorola,mot-cpcap
[Severity: Medium]
Since these new compatible strings are defined as standalone enums without a
generic fallback, will the core driver fail to probe these devices?
Looking at drivers/mfd/motorola-cpcap.c, cpcap_of_match[] lacks a match for
these specific strings:
static const struct of_device_id cpcap_of_match[] = {
{ .compatible = "motorola,cpcap", },
{ .compatible = "st,6556002", },
{},
};
Are there plans to update the driver's match table to recognize these new
standalone compatibles, or could a generic fallback like "motorola,cpcap" be
added to the bindings?
quoted hunk ↗ jump to hunk
+
+ - items:
+ - const: motorola,cpcap
+ - const: st,6556002
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721095654.429346-1-clamor95@gmail.com?part=4