Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] The commit message description following the subsystem prefix is not capitalized.
- [Low] The newly added YAML binding points to a non-existent MFD schema, and the parent MFD binding still points to the deleted text file.
- [Low] The YAML binding conversion omitted the `examples` block.
--
--- Patch [1]: [PATCH v7 1/6] dt-bindings: leds: leds-cpcap: convert to DT schema ---
commit 42a8d75469150373ffb675f9ae6fccd8e3d482d6
Author: Svyatoslav Ryhel [off-list ref]
dt-bindings: leds: leds-cpcap: convert to DT schema
Convert LEDs devicetree bindings for the Motorola CPCAP MFD from TXT to
YAML format. This patch does not change any functionality; the bindings
remain the same.
dt-bindings: leds: leds-cpcap: convert to DT schema
[Severity: Low]
This isn't a bug, but should the description following the subsystem prefix
be capitalized? The LED subsystem conventions typically expect a capitalized
description, such as "Convert to DT schema".
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml b/Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml
new file mode 100644
index 0000000000000..c8e7b88a05ccf
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/motorola,cpcap-leds.yaml
[ ... ]
quoted hunk ↗ jump to hunk
+description:
+ This module is part of the Motorola CPCAP MFD device. For more details
+ see Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml. LEDs are
+ represented as sub-nodes of the PMIC node on the device tree.
[Severity: Low]
Does motorola,cpcap.yaml exist yet? It looks like this references a
non-existent MFD schema. Additionally, the parent MFD binding in
Documentation/devicetree/bindings/mfd/motorola-cpcap.txt wasn't updated
to reflect the deletion of the old leds-cpcap.txt file.
[ ... ]
quoted hunk ↗ jump to hunk
+required:
+ - compatible
+ - label
+ - vdd-supply
+
+unevaluatedProperties: false
+
+...
[Severity: Low]
Should this YAML file include an examples block? The YAML conversion
drops the original usage example from the .txt file.
Running dt_binding_check on standalone schemas that lack an examples section
can result in warnings or incomplete schema validation.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721095654.429346-1-clamor95@gmail.com?part=1