Re: [PATCH v2 08/11] mfd: macsmc: Wire up Apple SMC HID subdevice
From: Janne Grunau <j@jannau.net>
Date: 2025-09-25 21:55:10
Also in:
asahi, linux-arm-kernel, linux-devicetree, linux-hwmon, linux-rtc, lkml
On Wed, Aug 27, 2025 at 09:22:42PM +1000, James Calligeros wrote:
quoted hunk ↗ jump to hunk
Add the new SMC HID function to the mfd device Signed-off-by: James Calligeros <redacted> --- drivers/mfd/macsmc.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/mfd/macsmc.c b/drivers/mfd/macsmc.c index 286dc150aa6cfdd6d29f769094278daaddabe7c3..893fc47d62b2c956d966d1841895a3fa2b9a3005 100644 --- a/drivers/mfd/macsmc.c +++ b/drivers/mfd/macsmc.c@@ -45,6 +45,7 @@ #define SMC_TIMEOUT_MS 500 static const struct mfd_cell apple_smc_devs[] = { + MFD_CELL_NAME("macsmc-hid"),
I think it would make sense to use MFD_CELL_OF and device nodes for all macsmc even though it's in the case of macsmc-input (or -hid) not strictly necessary
MFD_CELL_OF("macsmc-gpio", NULL, NULL, 0, 0, "apple,smc-gpio"),
MFD_CELL_OF("macsmc_hwmon", NULL, NULL, 0, 0, "apple,smc-hwmon"),
MFD_CELL_OF("macsmc-reboot", NULL, NULL, 0, 0, "apple,smc-reboot"),Janne