Re: [PATCH v2 10/11] arm64: dts: apple: Add common hwmon sensors and fans
From: Janne Grunau <j@jannau.net>
Date: 2025-09-25 22:02:57
Also in:
asahi, linux-arm-kernel, linux-devicetree, linux-hwmon, linux-rtc, lkml
On Wed, Aug 27, 2025 at 09:22:44PM +1000, James Calligeros wrote:
quoted hunk ↗ jump to hunk
Each Apple Silicon device exposes a unique set of sensors and fans, however some have been found to be reliably common across devices. Add these as .dtsi files so that they can be combined with any device-specific sensors without excessive repetition. Signed-off-by: James Calligeros <redacted> --- .../boot/dts/apple/hwmon-common.dtsi | 37 +++++++++++++++++++++++++ .../boot/dts/apple/hwmon-fan-dual.dtsi | 24 ++++++++++++++++ arch/arm64/boot/dts/apple/hwmon-fan.dtsi | 19 +++++++++++++ .../boot/dts/apple/hwmon-laptop.dtsi | 35 +++++++++++++++++++++++ .../boot/dts/apple/hwmon-mac-mini.dtsi | 17 ++++++++++++ 5 files changed, 132 insertions(+)diff --git a/arch/arm64/boot/dts/apple/hwmon-common.dtsi b/arch/arm64/boot/dts/apple/hwmon-common.dtsi new file mode 100644 index 0000000000000000000000000000000000000000..bac4e44d3f9892fe8ad04125e47dcccb2bcf57a0 --- /dev/null +++ b/arch/arm64/boot/dts/apple/hwmon-common.dtsi@@ -0,0 +1,37 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Hardawre monitoring sensors expected to be found on all Apple Silicon devices
typo: "Hardawre"
+ *
+ * Copyright The Asahi Linux Contributors
+ */
+
+&smc {
+ hwmon {
+ compatible = "apple,smc-hwmon";I think it woiuld make more sense to add the hwmon child node with the compatible in the SoC *.dtsi and then only add the sensor nodes to "&smc_hwmon" in these hwmon-*.dtsi files Janne