Re: [PATCH v4 03/10] pwm: max7360: Add MAX7360 PWM support
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
Date: 2025-02-14 16:05:28
Also in:
linux-devicetree, linux-gpio, linux-pwm, lkml
On Fri Feb 14, 2025 at 4:10 PM CET, Andy Shevchenko wrote:
On Fri, Feb 14, 2025 at 12:49:53PM +0100, mathieu.dubois-briand@bootlin.com wrote:quoted
From: Kamel Bouhara <kamel.bouhara@bootlin.com> Add driver for Maxim Integrated MAX7360 PWM controller, supporting up to 8 independent PWM outputs....quoted
+#include <linux/of.h>Is this used? Cargo cult?
Right, not used anymore.
quoted
+struct max7360_pwm {quoted
+ struct device *parent;Is it not the same as you can derive from regmap?
It is. I'm removing it. Also, max7360_pwm structure will only contain the regmap, so I will remove the structure and set the regmap directly as the pwm chip driver data.
...
I have fixed all other points. Thanks for your review! -- Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com