On Fri, Jun 14, 2024 at 04:27:52PM +0100, Conor Dooley wrote:

On Fri, Jun 14, 2024 at 08:15:38PM +0800, Charles Wang wrote:

quoted

The Goodix GT7986U touch controller report touch data according to the
HID protocol through the SPI bus. However, it is incompatible with
Microsoft's HID-over-SPI protocol.

quoted

+properties:
+  compatible:
+    enum:
+      - goodix,gt7986u

quoted

+  goodix,hid-report-addr:
+    description: the register address for retrieving HID report data.
+    $ref: /schemas/types.yaml#/definitions/uint32

You're also missing an explanation anywhere in the patch for why this
address varies between gt7986u devices.

Ack, I will add an explanation in the next commit.

The address variation between GT7986U devices is related to their firmware
versions. While we strive to maintain consistency, significant firmware
upgrades might necessitate changes to this address.

Charles

Thanks