Re: [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
From: Conor Dooley <conor@kernel.org>
Date: 2024-06-14 15:26:28
Also in:
linux-devicetree, lkml
On Fri, Jun 14, 2024 at 08:15:38PM +0800, Charles Wang wrote:
quoted hunk ↗ jump to hunk
The Goodix GT7986U touch controller report touch data according to the HID protocol through the SPI bus. However, it is incompatible with Microsoft's HID-over-SPI protocol. Signed-off-by: Charles Wang <redacted> --- .../bindings/input/goodix,gt7986u.yaml | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yamldiff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml new file mode 100644 index 000000000..1c518d03b --- /dev/null +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml@@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GOODIX GT7986U SPI HID Touchscreen + +maintainers: + - Charles Wang <charles.goodix@gmail.com> + +description: + Supports the Goodix GT7986U touchscreen. + This touch controller reports data packaged according to the HID protocol, + but is incompatible with Microsoft's HID-over-SPI protocol. + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - goodix,gt7986u + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + reset-gpios: + maxItems: 1 + description: reset gpio the chip is connected to. + + goodix,hid-report-addr: + description: the register address for retrieving HID report data. + $ref: /schemas/types.yaml#/definitions/uint32 + +additionalProperties: false
unevaluatedProperties: false. Please test your binding w/ dt_binding_check.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - goodix,hid-report-addr
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/gpio/gpio.h>
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ num-cs = <1>;
+ cs-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>;cs-gpios shouldn't be needed for a basic example. Blank line here before the child node please. Thanks, Conor.
+ touchscreen@0 {
+ compatible = "goodix,gt7986u";
+ reg = <0>;
+ interrupt-parent = <&gpio>;
+ interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
+ spi-max-frequency = <10000000>;
+ goodix,hid-report-addr = <0x22c8c>;
+ };
+ };
--
2.43.0
Attachments
- signature.asc [application/pgp-signature] 228 bytes