Thread (67 messages) 67 messages, 8 authors, 2023-11-13

Re: [PATCH 27/52] input: wm831x-on - Convert to platform remove callback returning void

From: Charles Keepax <ckeepax@opensource.cirrus.com>
Date: 2023-09-20 14:24:21

On Wed, Sep 20, 2023 at 02:58:04PM +0200, Uwe Kleine-König wrote:
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <redacted>
---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help