Hi,
On Fri, Jun 9, 2023 at 9:14 AM Doug Anderson [off-list ref] wrote:
Hi,
On Thu, Jun 8, 2023 at 11:36 PM Cong Yang
[off-list ref] wrote:
quoted
The ili9882t is a TDDI IC (Touch with Display Driver). The
datasheet specifies there should be 60ms between touch SDA
sleep and panel RESX. Doug's series[1] allows panels and
touchscreens to power on/off together, so we can add the 65 ms
delay in i2c_hid_core_suspend before panel_unprepare.
Because ili9882t touchscrgeen is a panel follower, and
needs to use vccio-supply instead of vcc33-supply, so set
it NULL to ili9882t_chip_data, then not use vcc33 regulator.
[1]: https://lore.kernel.org/r/20230607215224.2067679-1-dianders@chromium.org (local)
Signed-off-by: Cong Yang <redacted>
---
drivers/hid/i2c-hid/i2c-hid-of-elan.c | 50 ++++++++++++++++++++-------
1 file changed, 38 insertions(+), 12 deletions(-)
This seems reasonable to me now, but only makes sense to land if the
panel follower patch series [1] lands. That series is currently at v2
and will at least need a v3.
[1] https://lore.kernel.org/r/20230607215224.2067679-1-dianders@chromium.org (local)
Oh, but I should have added:
Reviewed-by: Douglas Anderson <dianders@chromium.org>