Re: [PATCH v5 1/2] dt-bindings: HID: i2c-hid: ilitek: Introduce bindings for Ilitek ili9882t
From: Krzysztof Kozlowski <hidden>
Date: 2023-06-09 16:01:11
Also in:
linux-devicetree, lkml
From: Krzysztof Kozlowski <hidden>
Date: 2023-06-09 16:01:11
Also in:
linux-devicetree, lkml
On 09/06/2023 08:36, Cong Yang wrote:
The ili9882t touch screen chip same as Elan eKTH6915 controller has a reset gpio. The difference is that ili9882t needs to use vccio-supply instead of vcc33-supply. Doug's series[1] allows panels and touchscreens to power on/off together, let's add a phandle for this. [1]: https://lore.kernel.org/r/20230607215224.2067679-1-dianders@chromium.org (local) Signed-off-by: Cong Yang <redacted>
Reviewed-by: Krzysztof Kozlowski <redacted> If there is going to be new version, then: A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. --- This is an automated instruction, just in case, because many review tags are being ignored. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 Best regards, Krzysztof