Thread (22 messages) 22 messages, 6 authors, 2023-02-08

Re: [PATCH v3 06/12] gpiolib: split linux/gpio/driver.h out of linux/gpio.h

From: Linus Walleij <hidden>
Date: 2023-02-08 14:55:42
Also in: linux-acpi, linux-arch, linux-arm-kernel, linux-devicetree, linux-doc, linux-gpio, linux-m68k, linux-media, linux-omap, linux-samsung-soc, linux-sh, linux-wireless, linuxppc-dev, lkml, netdev

On Wed, Feb 8, 2023 at 3:51 PM Andy Shevchenko
[off-list ref] wrote:
On Wed, Feb 08, 2023 at 12:55:06AM +0200, Andy Shevchenko wrote:
quoted
On Tue, Feb 07, 2023 at 03:55:23PM +0100, Linus Walleij wrote:
quoted
On Tue, Feb 7, 2023 at 3:29 PM Andy Shevchenko
[off-list ref] wrote:
quoted
From: Arnd Bergmann <arnd@arndb.de>

Almost all gpio drivers include linux/gpio/driver.h, and other
files should not rely on includes from this header.

Remove the indirect include from here and include the correct
headers directly from where they are used.
...
quoted
Make sure you push this to the kernel.org build servers (zeroday builds),
Of course, that is the purpose of publishing this before the release (so we
will have some TODO list that eventually this can be applied for v6.4-rc1).
quoted
I think this patch needs to hit some more files, in my tests with a similar
patch at least these:
Right. I forgot to also incorporate your stuff into this series.
Do you have anything that I can take as is?
I'm going to incorporate the following:

        gpio: Make the legacy <linux/gpio.h> consumer-only
        ARM: s3c24xx: Use the right include
        ARM: orion/gpio: Use the right include
        hte: tegra-194: Use proper includes
        pcmcia: pxa2xx_viper: Include dependency
Excellent, thanks. I don't care about being credited, just want things
to go smooth so you run into less snags.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help