Re: [PATCH v3 08/12] gpio: aggregator: Add missing header(s)
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2023-02-08 10:09:17
Also in:
linux-acpi, linux-arch, linux-devicetree, linux-doc, linux-gpio, linux-m68k, linux-media, linux-omap, linux-samsung-soc, linux-sh, linux-wireless, linuxppc-dev, lkml, netdev
Hi Andy, Thanks for your patch! On Tue, Feb 7, 2023 at 3:29 PM Andy Shevchenko [off-list ref] wrote:
Do not imply that some of the generic headers may be always included. Instead, include explicitly what we are direct user of.
That applies only to the addition of #include <linux/slab.h>... Please also describe the other changes.
quoted hunk ↗ jump to hunk
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-aggregator.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index 6d17d262ad91..20a686f12df7 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c@@ -10,19 +10,20 @@ #include <linux/bitmap.h> #include <linux/bitops.h> #include <linux/ctype.h> -#include <linux/gpio.h> -#include <linux/gpio/consumer.h> -#include <linux/gpio/driver.h> -#include <linux/gpio/machine.h> #include <linux/idr.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/mutex.h> #include <linux/overflow.h> #include <linux/platform_device.h> +#include <linux/slab.h> #include <linux/spinlock.h> #include <linux/string.h> +#include <linux/gpio/consumer.h> +#include <linux/gpio/driver.h> +#include <linux/gpio/machine.h> + #define AGGREGATOR_MAX_GPIOS 512
For the actual changes:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds