Thread (21 messages) 21 messages, 5 authors, 2022-08-22

Re: [PATCH 4/4] input: joystick: Fix buffer data parsing

From: Jonathan Cameron <jic23@kernel.org>
Date: 2022-08-22 19:36:05
Also in: linux-iio, linux-mips, lkml

quoted
quoted
  		case 2:
 -			data_u16 = (const u16 *)data + idx;
 -
  			/*
  			 * Data is aligned to the sample size by IIO core.
  			 * Call `get_unaligned_xe16` to hide type casting.
  			 */
  			if (endianness == IIO_BE)
 -				val = get_unaligned_be16(data_u16);
 +				val = get_unaligned_be16(chan_data);  
I obviously missed this previously but these are aligned so we don't 
need the
unaligned form.  
Yes, the comment above says that it's used to hide type casting.
oops :)

Thanks for pointing out my lack of observation!

Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help