Re: [PATCH 0/4] iio/adc-joystick: buffer data parsing fixes
From: Chris Morgan <hidden>
Date: 2022-08-18 18:28:56
Also in:
linux-iio, linux-mips, lkml
On Wed, Aug 17, 2022 at 12:56:39PM +0200, Artur Rojek wrote:
Hi all, this patch set fixes the way channel data is being parsed in the adc-joystick driver. To achieve that, it also introduces helpers in the IIO subsystem. As a side effect of those changes, a bug in ingenic-adc has been exposed, which this patch set promptly rectifies. Tested on GCW Zero (by me) and on Anbernic RG350 (by Paul). Chris: As you have originally reported the issue, would you be able to test the above changes on your setup (Odroid Go Advance, was it)?
I can confirm this fixes the issue I experienced, I can see both channels of the joystick now when using an hrtimer as a trigger. This patch also does not interfere with the polling work in progress, as that still works as expected too (polling work is still desired though). Thank you.
Artur Rojek (4): iio/adc: ingenic: fix channel offsets in buffer iio: add iio_channel_cb_get_iio_buffer helper iio: add helper function for reading channel offset in buffer input: joystick: Fix buffer data parsing drivers/iio/adc/ingenic-adc.c | 7 +++--- drivers/iio/buffer/industrialio-buffer-cb.c | 7 ++++++ drivers/iio/industrialio-buffer.c | 28 +++++++++++++++++++++ drivers/input/joystick/adc-joystick.c | 26 ++++++++++++------- include/linux/iio/buffer.h | 4 +++ include/linux/iio/consumer.h | 12 +++++++++ 6 files changed, 71 insertions(+), 13 deletions(-) -- 2.37.2