Thread (2 messages) 2 messages, 2 authors, 2022-07-06

Re: [PATCH 6/6] i2c: Make remove callback return void

From: Uwe Kleine-König <hidden>
Date: 2022-07-06 09:32:33
Also in: alsa-devel, chrome-platform, dri-devel, linux-arm-kernel, linux-clk, linux-crypto, linux-devicetree, linux-fbdev, linux-gpio, linux-hwmon, linux-i2c, linux-iio, linux-integrity, linux-leds, linux-media, linux-mediatek, linux-omap, linux-pm, linux-pwm, linux-rtc, linux-serial, linux-staging, linux-usb, linux-watchdog, linuxppc-dev, netdev, platform-driver-x86

On Wed, Jul 06, 2022 at 12:13:15PM +0300, Vladimir Oltean wrote:
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote:
quoted
From: Uwe Kleine-König <redacted>

The value returned by an i2c driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)

So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.

Signed-off-by: Uwe Kleine-König <redacted>
---
Assuming you remove the spurious kasan change:
It's already gone in my tree, see
https://git.pengutronix.de/cgit/ukl/linux/commit/?h=i2c-remove-void
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help