Re: [PATCH 6/6] i2c: Make remove callback return void
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2022-07-06 09:14:07
Also in:
alsa-devel, chrome-platform, dri-devel, linux-arm-kernel, linux-clk, linux-crypto, linux-devicetree, linux-fbdev, linux-gpio, linux-hwmon, linux-i2c, linux-iio, linux-integrity, linux-leds, linux-media, linux-mediatek, linux-omap, linux-pm, linux-pwm, linux-rtc, linux-serial, linux-staging, linux-usb, linux-watchdog, linuxppc-dev, netdev, platform-driver-x86
Possibly related (same subject, not in this thread)
- 2022-07-09 · Re: [PATCH 6/6] i2c: Make remove callback return void · Dmitry Torokhov <dmitry.torokhov@gmail.com>
- 2022-07-05 · Re: [PATCH 6/6] i2c: Make remove callback return void · Uwe Kleine-König <hidden>
- 2022-07-05 · Re: [PATCH 6/6] i2c: Make remove callback return void · Jean Delvare <hidden>
- 2022-06-29 · Re: [PATCH 6/6] i2c: Make remove callback return void · Luca Ceresoli <luca@lucaceresoli.net>
- 2022-06-29 · Re: [PATCH 6/6] i2c: Make remove callback return void · Maximilian Luz <luzmaximilian@gmail.com>
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote:
From: Uwe Kleine-König <redacted> The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Signed-off-by: Uwe Kleine-König <redacted> ---
Assuming you remove the spurious kasan change: Reviewed-by: Vladimir Oltean <olteanv@gmail.com>