Thread (51 messages) 51 messages, 7 authors, 2022-07-19

Re: [PATCH bpf-next v6 21/23] samples/bpf: add new hid_mouse example

From: Benjamin Tissoires <hidden>
Date: 2022-07-13 12:32:35
Also in: bpf, linux-doc, linux-kselftest, lkml, netdev

On Wed, Jul 13, 2022 at 2:16 PM Dominique Martinet
[off-list ref] wrote:
Benjamin Tissoires wrote on Tue, Jul 12, 2022 at 04:58:48PM +0200:
quoted
diff --git a/samples/bpf/hid_mouse.c b/samples/bpf/hid_mouse.c
new file mode 100644
index 000000000000..f6e5f09026eb
--- /dev/null
+++ b/samples/bpf/hid_mouse.c
@@ -0,0 +1,150 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/* Copyright (c) 2022 Benjamin Tissoires
+ */
+
+/* not sure why but this doesn't get preoperly imported */
typo: properly
quoted
+#define __must_check
But more usefully, I don't think it should be needed -- we don't use
__must_check at all in uapi includes; if this is needed that means some
of the include here uses the kernel internal includes and that shouldn't
be needed as they're not normally installed.
Indeed, I must have had the issue in the early days of development.
Removing the line still makes the program compile, so I'll remove it
in v7.

Thanks a lot!

Cheers,
Benjamin
Didn't actually try to see but taking the compilation line that fails
and running it with -E will probably show where that must_check comes
from

--
Dominique Martinet | Asmadeus,
just passing by
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help