Hi Dmitry,
On 12/11/21 04:07, Dmitry Torokhov wrote:
Hi Hans,
On Mon, Nov 22, 2021 at 11:06:37PM +0100, Hans de Goede wrote:
quoted
+ input_set_capability(data->pen_input, EV_KEY, BTN_TOUCH);
+ input_set_capability(data->pen_input, EV_KEY, BTN_TOOL_PEN);
+ /*
+ * We never report BTN_STYLUS but userspace want to see this in order
+ * for the device to be recognized as a pen / drawing-tablet.
+ */
What userspace is that? I see that udev recognizes devices with either
stylus or pen as tablets since at least 2015.
I am really hesitant adding synthetic capabilities that do not have real
events behind them.
You are completely right, I added this when GNOME3 / libinput would not
recognize the pen (looking at other stylus/pen drivers) but IIRC things
then still did not work and then I also added code to set the resolution.
I just tested without setting BTN_STYLUS and things still work fine,
so the comment and the line setting BTN_STYLUS can be dropped while
merging this. Let me know if you want me to do a new version with this
dropped instead.
Regards,
Hans