Re: [PATCH resend 2/2] Input: silead - Add pen support
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-12-11 03:08:02
Hi Hans, On Mon, Nov 22, 2021 at 11:06:37PM +0100, Hans de Goede wrote:
quoted hunk ↗ jump to hunk
+ input_set_capability(data->pen_input, EV_KEY, BTN_TOUCH); + input_set_capability(data->pen_input, EV_KEY, BTN_TOOL_PEN); + /* + * We never report BTN_STYLUS but userspace want to see this in order + * for the device to be recognized as a pen / drawing-tablet. + */
What userspace is that? I see that udev recognizes devices with either stylus or pen as tablets since at least 2015. I am really hesitant adding synthetic capabilities that do not have real events behind them. Thanks. -- Dmitry