Re: [PATCH 2/4] Input: goodix - Improve gpiod_get() error logging

Hi Dmitry,

On 12/7/21 08:31, Dmitry Torokhov wrote:

Hi Hans,

On Mon, Dec 06, 2021 at 05:47:45PM +0100, Hans de Goede wrote:

quoted

goodix_get_gpio_config() errors are fatal (abort probe()) so log them
at KERN_ERR level rather then as debug messages.

This change uses dev_err_probe() to automatically suppress the errors
in case of -EPROBE_DEFER.

I really believe that dev_err_probe() is wrong API as the providers
should be setting the reason for deferred probe failures.

Could you simply swap dev_dbg() for dev_err()?

Done for v2, which I'm sending out right away.

Note I've dropped the first patch for v2 since you said you
applied this.

Regards,

Hans


p.s.

Any chance you could also take a look at this 2 patch patch-series,
this has been pending for a while now:

https://lore.kernel.org/linux-input/20211122220637.11386-1-hdegoede@redhat.com/T/#t (local)