Re: [PATCH 2/4] Input: goodix - Improve gpiod_get() error logging

Hi Hans,

On Mon, Dec 06, 2021 at 05:47:45PM +0100, Hans de Goede wrote:

goodix_get_gpio_config() errors are fatal (abort probe()) so log them
at KERN_ERR level rather then as debug messages.

This change uses dev_err_probe() to automatically suppress the errors
in case of -EPROBE_DEFER.

I really believe that dev_err_probe() is wrong API as the providers
should be setting the reason for deferred probe failures.

Could you simply swap dev_dbg() for dev_err()?

Thanks.

-- 
Dmitry