Re: [PATCH] Input: hideep - fix the uninitialized use in hideep_nvm_unlock()

Dimitry:

Sorry for the inconvenience, I would build the changes next time.
Thanks for your help : )

On Sat, Jun 19, 2021 at 10:35 PM Dmitry Torokhov
[off-list ref] wrote:

On Sat, Jun 19, 2021 at 10:26:40PM -0700, Dmitry Torokhov wrote:

quoted

On Sat, Jun 19, 2021 at 10:10:37PM -0700, Dmitry Torokhov wrote:

quoted

On Wed, Jun 16, 2021 at 03:48:51PM -0700, Yizhuo Zhai wrote:

quoted

Inside function hideep_nvm_unlock(), variable "unmask_code" could
be uninitialized if hideep_pgm_r_reg() returns error, however, it
is used in the later if statement after an "and" operation, which
is potentially unsafe.

I think this is pretty sensible, but let's see if the original author
has some comments...

I guess not. Oh well...

Applied, thank you.

Note that I had to make some changes to make it compile. Please next
time try building your changes before posting them,

Thanks.

--
Dmitry

-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside