Re: [PATCH] Input: hideep - fix the uninitialized use in hideep_nvm_unlock()
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-06-20 05:26:47
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2021-06-15 · Re: [PATCH] Input: hideep - fix the uninitialized use in hideep_nvm_unlock() · Dmitry Torokhov <dmitry.torokhov@gmail.com>
- 2021-06-15 · Re: [PATCH] Input: hideep - fix the uninitialized use in hideep_nvm_unlock() · Yizhuo Zhai <hidden>
- 2021-06-15 · Re: [PATCH] Input: hideep - fix the uninitialized use in hideep_nvm_unlock() · Dmitry Torokhov <dmitry.torokhov@gmail.com>
- 2021-06-15 · [PATCH] Input: hideep - fix the uninitialized use in hideep_nvm_unlock() · Yizhuo Zhai <hidden>
On Sat, Jun 19, 2021 at 10:10:37PM -0700, Dmitry Torokhov wrote:
On Wed, Jun 16, 2021 at 03:48:51PM -0700, Yizhuo Zhai wrote:quoted
Inside function hideep_nvm_unlock(), variable "unmask_code" could be uninitialized if hideep_pgm_r_reg() returns error, however, it is used in the later if statement after an "and" operation, which is potentially unsafe.I think this is pretty sensible, but let's see if the original author has some comments...
I guess not. Oh well... Applied, thank you. -- Dmitry