Hi Geert,

On 26/05/21 7:20 pm, Geert Uytterhoeven wrote:

Hi Randy,

On Wed, May 26, 2021 at 9:03 AM Randy Dunlap [off-list ref] wrote:

quoted

MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.

WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
   Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
   Selected by [y]:
   - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]

Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
Signed-off-by: Randy Dunlap <redacted>

Thanks for your patch!

quoted

--- linux-next-20210525.orig/drivers/input/mouse/Kconfig
+++ linux-next-20210525/drivers/input/mouse/Kconfig

@@ -348,6 +348,7 @@ config MOUSE_AMIGA

  config MOUSE_ATARI
         tristate "Atari mouse"
+       depends on INPUT_KEYBOARD
         depends on ATARI
         select ATARI_KBD_CORE
         help

It looks like arch/m68k/atari/atakeyb.c doesn't use anything from the
input subsystem, so I think you can move the ATARI_KBD_CORE symbol
outside the "if INPUT_KEYBOARD" section instead.

Correct - while we're at it, what about moving it to 
arch/m68k/Kconfig.machine?

Cheers,

     Michael

Gr{oetje,eeting}s,

                         Geert