Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning
From: Michael Schmitz <schmitzmic@gmail.com>
Date: 2021-05-26 19:16:34
Also in:
lkml
Randy, On 26/05/21 7:03 pm, Randy Dunlap wrote:
MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.
Right you are! Thanks for spotting this. Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>
quoted hunk ↗ jump to hunk
WARNING: unmet direct dependencies detected for ATARI_KBD_CORE Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n] Selected by [y]: - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y] Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.") Signed-off-by: Randy Dunlap <redacted> Cc: Michael Schmitz <redacted> Cc: Roman Zippel <redacted> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org --- drivers/input/mouse/Kconfig | 1 + 1 file changed, 1 insertion(+)--- linux-next-20210525.orig/drivers/input/mouse/Kconfig +++ linux-next-20210525/drivers/input/mouse/Kconfig@@ -348,6 +348,7 @@ config MOUSE_AMIGA config MOUSE_ATARI tristate "Atari mouse" + depends on INPUT_KEYBOARD depends on ATARI select ATARI_KBD_CORE help