Thread (38 messages) 38 messages, 3 authors, 2021-04-08

Re: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description

From: Benjamin Tissoires <hidden>
Date: 2021-04-07 16:57:02
Also in: linux-usb, lkml

On Fri, Mar 26, 2021 at 3:35 PM Lee Jones [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Fixes the following W=1 kernel build warning(s):

 drivers/hid/usbhid/usbkbd.c:66: warning: bad line:                 should be on

Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: message to <redacted>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
 drivers/hid/usbhid/usbkbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index d5b7a696a68c5..d0c640be8a885 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = {
  *             new key is pressed or a key that was pressed is released.
  * @led:       URB for sending LEDs (e.g. numlock, ...)
  * @newleds:   data that will be sent with the @led URB representing which LEDs
-               should be on
+ *             should be on
nitpick: checkpatch complains about spaces before tabs here.

I amended locally and will push the fixed version.

Cheers,
Benjamin
  * @name:      Name of the keyboard. @dev's name field points to this buffer
  * @phys:      Physical path of the keyboard. @dev's phys field points to this
  *             buffer
--
2.27.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help