[PATCH 1/3] input: gpio-keys: Remove extra call to input_sync · Paul Cercueil <paul@crapouillou.net> · 2021-03-05
[PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce · Paul Cercueil <paul@crapouillou.net> · 2021-03-05
Re: [PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-03-05
Re: [PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce · Paul Cercueil <paul@crapouillou.net> · 2021-03-05
Re: [PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-03-07
Re: [PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce · Paul Cercueil <paul@crapouillou.net> · 2021-03-07
Re: [PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-03-07
[PATCH 2/3] input: gpio-keys: Use hrtimer for release timer · Paul Cercueil <paul@crapouillou.net> · 2021-03-05
Re: [PATCH 1/3] input: gpio-keys: Remove extra call to input_sync · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-03-05

Re: [PATCH 1/3] input: gpio-keys: Remove extra call to input_sync

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-03-05 18:40:53
Also in: lkml

On Fri, Mar 05, 2021 at 05:01:09PM +0000, Paul Cercueil wrote:

The input_sync() function will already be called within
gpio_keys_gpio_report_event(), so there's no need to call it again after
the loop in gpio_keys_report_state().

I'd probably go other way around and remove the sync from
gpio_keys_report_state() and add one to gpio_keys_gpio_work_func() so
that we do not have to send bunch of input_sync() when there are several
keys/buttons.

Thanks.

-- 
Dmitry

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help