Thread (23 messages) 23 messages, 2 authors, 2021-01-26

Re: [PATCH 02/10] input: iqs5xx: Preserve bootloader errors

flat view

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-01-25 04:17:13

On Mon, Jan 18, 2021 at 02:43:38PM -0600, Jeff LaBundy wrote:
After user space writes the fw_file attribute to push new firmware
to the device, the driver calls iqs5xx_dev_init() to re-initialize
the device with the updated firmware or recover the device in case
the update failed.

In the case of the latter, however, iqs5xx_fw_file_write() returns
zero (success) so long as iqs5xx_dev_init() does not fail, and any
error encountered during the update process is lost. Solve this by
saving the error before calling iqs5xx_dev_init().

Signed-off-by: Jeff LaBundy <redacted>
Applied, thank you.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help