Re: [PATCH 07/15] input: touchscreen: usbtouchscreen: Remove unused variable 'ret'
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-11-13 07:37:01
Also in:
lkml
On Thu, Nov 12, 2020 at 11:01:56AM +0000, Lee Jones wrote:
quoted hunk ↗ jump to hunk
Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’: drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Henrik Rydberg <rydberg@bitmath.org> Cc: James Hilliard <redacted> Cc: Daniel Ritz <redacted> Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones <redacted> --- drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c index 397cb1d3f481b..c3b7130cd9033 100644 --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c@@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) unsigned int data_len = be16_to_cpu(packet->data_len); unsigned int x_len = be16_to_cpu(packet->x_len); unsigned int y_len = be16_to_cpu(packet->y_len); - int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; + int x, y, begin_x, begin_y, end_x, end_y, w, h; /* got touch data? */ if ((pkt[0] & 0xe0) != 0xe0)@@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) x_len -= 0x80; /* send ACK */ - ret = usb_submit_urb(priv->ack, GFP_ATOMIC); + usb_submit_urb(priv->ack, GFP_ATOMIC);
I wonder if we should handle potential errors instead.
if (!usbtouch->type->max_xc) {
usbtouch->type->max_xc = 2 * x_len;
--
2.25.1Thanks. -- Dmitry