Re: [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed

[PATCH v3 00/11] Raspberry Pi PoE HAT fan support · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() · Nicolas Saenz Julienne <hidden> · 2020-11-04
Re: [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() · Bartosz Golaszewski <hidden> · 2020-11-05
Re: [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() · Nicolas Saenz Julienne <hidden> · 2020-11-05
Re: [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() · Bartosz Golaszewski <hidden> · 2020-11-05
Re: [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() · Nicolas Saenz Julienne <hidden> · 2020-11-10
[PATCH v3 04/11] reset: raspberrypi: Release firmware handle on unbind · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 06/11] staging: vchiq: Release firmware handle on unbind · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 02/11] clk: bcm: rpi: Release firmware handle on unbind · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus · Nicolas Saenz Julienne <hidden> · 2020-11-04
Re: [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus · Rob Herring <robh@kernel.org> · 2020-11-04
Re: [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 11/11] pwm: Add Raspberry Pi Firmware based PWM bus · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 05/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 03/11] gpio: raspberrypi-exp: Release firmware handle on unbind · Nicolas Saenz Julienne <hidden> · 2020-11-04
Re: [PATCH v3 03/11] gpio: raspberrypi-exp: Release firmware handle on unbind · Bartosz Golaszewski <hidden> · 2020-11-05
[PATCH v3 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 08/11] firmware: raspberrypi: Get rid of rpi_firmware_get() · Nicolas Saenz Julienne <hidden> · 2020-11-04
[PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed · Nicolas Saenz Julienne <hidden> · 2020-11-04
Re: [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2020-11-12
Re: [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed · Nicolas Saenz Julienne <hidden> · 2020-11-12

From: Nicolas Saenz Julienne <hidden>
Date: 2020-11-12 09:08:17
Also in: linux-arm-kernel, linux-clk, linux-devicetree, linux-gpio, linux-pwm, lkml

On Wed, 2020-11-11 at 17:45 -0800, Dmitry Torokhov wrote:

Hi Nicolas,

On Wed, Nov 04, 2020 at 11:39:33AM +0100, Nicolas Saenz Julienne wrote:

quoted

Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.

Unless I am mistaken this driver does not really need the firmware
structure past rpi_ts_probe(), and will be fine if it disappears earlier
than unbind time.

Yes, I missed that. Will update it.

Regards,
Nicolas

Attachments

signature.asc [application/pgp-signature] 488 bytes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help