Re: [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed
flat view
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-11-12 05:33:22
Also in:
linux-arm-kernel, linux-clk, linux-devicetree, linux-gpio, linux-pwm, lkml
Hi Nicolas, On Wed, Nov 04, 2020 at 11:39:33AM +0100, Nicolas Saenz Julienne wrote:
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device.
Unless I am mistaken this driver does not really need the firmware structure past rpi_ts_probe(), and will be fine if it disappears earlier than unbind time. Thanks.
quoted hunk ↗ jump to hunk
Signed-off-by: Nicolas Saenz Julienne <redacted> --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/input/touchscreen/raspberrypi-ts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/raspberrypi-ts.c b/drivers/input/touchscreen/raspberrypi-ts.c index ef6aaed217cf..efed0efa91d9 100644 --- a/drivers/input/touchscreen/raspberrypi-ts.c +++ b/drivers/input/touchscreen/raspberrypi-ts.c@@ -134,7 +134,7 @@ static int rpi_ts_probe(struct platform_device *pdev) return -ENOENT; } - fw = rpi_firmware_get(fw_node); + fw = devm_rpi_firmware_get(&pdev->dev, fw_node); of_node_put(fw_node); if (!fw) return -EPROBE_DEFER;-- 2.29.1
-- Dmitry