Thread (57 messages) flat view 57 messages, 5 authors, 2020-08-28

Re: [PATCH 09/24] Input: bu21013_ts - Simplify with dev_err_probe()

From: Andy Shevchenko <hidden>
Date: 2020-08-27 09:10:56
Also in: lkml, platform-driver-x86

On Wed, Aug 26, 2020 at 9:19 PM Krzysztof Kozlowski [off-list ref] wrote:
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.
        ts->cs_gpiod = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH);
        error = PTR_ERR_OR_ZERO(ts->cs_gpiod);
+       if (error)
+               return dev_err_probe(&client->dev, error, "failed to get CS GPIO\n");
+
if (IS_ERR())
 return ... PTR_ERR()...


-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help