Thread (57 messages) flat view 57 messages, 5 authors, 2020-08-28

Re: [PATCH 06/24] Input: pwm-vibra - Simplify with dev_err_probe()

From: Andy Shevchenko <hidden>
Date: 2020-08-27 09:07:06
Also in: lkml, platform-driver-x86

On Wed, Aug 26, 2020 at 9:18 PM Krzysztof Kozlowski [off-list ref] wrote:
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.
        err = PTR_ERR_OR_ZERO(vibrator->vcc);
+       if (err)
+               return dev_err_probe(&pdev->dev, err, "Failed to request regulator\n");
Same comment, no need to have additional PTR_ERR_OZR_ZERO().

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help