Re: [PATCH v9 2/3] drivers: input: keyboard: Add mtk keypad driver
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2020-05-27 09:50:55
Also in:
linux-arm-kernel, linux-mediatek
Possibly related (same subject, not in this thread)
- 2020-05-27 · Re: [PATCH v9 2/3] drivers: input: keyboard: Add mtk keypad driver · Marco Felsch <hidden>
On Wed, May 27, 2020 at 11:00:48AM +0200, Marco Felsch wrote:
On 20-05-27 16:31, Fengping Yu wrote:
quoted
+ irqnr = platform_get_irq(pdev, 0); + if (irqnr < 0) + return -irqnr;^ irqnr is already negativequoted
+ ret = devm_request_threaded_irq(&pdev->dev, irqnr, + NULL, kpd_irq_handler, 0, + MTK_KPD_NAME, keypad); + if (ret) { + dev_err(&pdev->dev, "Failed to request IRQ#%d:%d\n", + irqnr, ret);Still not alligned.quoted
+ return ret; + }
And on top, can't we use irq instead of irqnr? -- With Best Regards, Andy Shevchenko