Re: [PATCH v9 2/3] drivers: input: keyboard: Add mtk keypad driver
From: Marco Felsch <hidden>
Date: 2020-05-27 09:09:58
Also in:
linux-arm-kernel, linux-mediatek
Hi, just found another typo. On 20-05-27 16:31, Fengping Yu wrote:
From: "fengping.yu" <redacted>
...
+static const struct of_device_id kpd_of_match[] = {
+ {.compatible = "mediatek, mt6779-keypad"},^ This is wrong
+ {.compatible = "mediatek,kp"},I would also drop the generic "mediatek,kp" compatible. Instead we should list all supported SoCs here. Regards, Marco
+ {/* sentinel */}
+};
+
+static struct platform_driver kpd_pdrv = {
+ .probe = kpd_pdrv_probe,
+ .driver = {
+ .name = MTK_KPD_NAME,
+ .of_match_table = kpd_of_match,
+ },
+};
+module_platform_driver(kpd_pdrv);
+
+MODULE_AUTHOR("Mediatek Corporation");
+MODULE_DESCRIPTION("MTK Keypad (KPD) Driver");
+MODULE_LICENSE("GPL");
--
2.18.0