Thread (6 messages) flat view 6 messages, 2 authors, 2020-03-10

Re: [PATCH 2/2] Input: goodix - Ignore spurious interrupts

From: Hans de Goede <hidden>
Date: 2020-03-10 14:55:42

Hi,

On 3/10/20 2:17 PM, Dmitry Mastykin wrote:

This patch completely lacks a "body" for the commit message,
please write a paragraph about why you are making this change
here.

Regards,

Hans

quoted hunk ↗ jump to hunk
Signed-off-by: Dmitry Mastykin <redacted>
---
  drivers/input/touchscreen/goodix.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 6a7ecc6..7f8ad6d 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -329,7 +329,7 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data)
  	 * The Goodix panel will send spurious interrupts after a
  	 * 'finger up' event, which will always cause a timeout.
  	 */
-	return 0;
+	return -ENOMSG;
  }
  
  static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 *coor_data)
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help