RE: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case
From: Peng Fan <peng.fan@nxp.com>
Date: 2020-03-09 13:40:28
Also in:
linux-arm-kernel, linux-pm, linux-rtc, linux-watchdog, lkml
Subject: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case
I have one patch pending reviewing. https://patchwork.kernel.org/patch/11395247/ Thanks, Peng.
quoted hunk ↗ jump to hunk
Add stubs for those i.MX SCU APIs to make those modules depending on IMX_SCU can pass build when COMPILE_TEST is enabled. Signed-off-by: Anson Huang <redacted> --- Changes since V2: - return error for stubs. --- include/linux/firmware/imx/ipc.h | 11 +++++++++++ include/linux/firmware/imx/sci.h | 19 +++++++++++++++++++ 2 files changed, 30 insertions(+)diff --git a/include/linux/firmware/imx/ipc.hb/include/linux/firmware/imx/ipc.h index 8910574..9e3d808 100644--- a/include/linux/firmware/imx/ipc.h +++ b/include/linux/firmware/imx/ipc.h@@ -34,6 +34,7 @@ struct imx_sc_rpc_msg { uint8_t func; }; +#ifdef CONFIG_IMX_SCU /* * This is an function to send an RPC message over an IPC channel. * It is called by client-side SCFW API function shims.@@ -55,4 +56,14 @@ int imx_scu_call_rpc(struct imx_sc_ipc *ipc, void *msg,bool have_resp); * @return Returns an error code (0 = success, failed if < 0) */ int imx_scu_get_handle(struct imx_sc_ipc **ipc); +#else +static inline int imx_scu_call_rpc(struct imx_sc_ipc *ipc, void *msg, +bool have_resp) { + return -ENOENT; +} +static inline int imx_scu_get_handle(struct imx_sc_ipc **ipc) { + return -ENOENT; +} +#endif #endif /* _SC_IPC_H */diff --git a/include/linux/firmware/imx/sci.hb/include/linux/firmware/imx/sci.h index 17ba4e4..022129b 100644--- a/include/linux/firmware/imx/sci.h +++ b/include/linux/firmware/imx/sci.h@@ -16,8 +16,27 @@ #include <linux/firmware/imx/svc/misc.h> #include<linux/firmware/imx/svc/pm.h> +#ifdef CONFIG_IMX_SCU int imx_scu_enable_general_irq_channel(struct device *dev); int imx_scu_irq_register_notifier(struct notifier_block *nb); int imx_scu_irq_unregister_notifier(struct notifier_block *nb); int imx_scu_irq_group_enable(u8 group, u32 mask, u8 enable); +#else +static inline int imx_scu_enable_general_irq_channel(struct device +*dev) { + return -ENOENT; +} +static inline int imx_scu_irq_register_notifier(struct notifier_block +*nb) { + return -ENOENT; +} +static inline int imx_scu_irq_unregister_notifier(struct notifier_block +*nb) { + return -ENOENT; +} +static inline int imx_scu_irq_group_enable(u8 group, u32 mask, u8 +enable) { + return -ENOENT; +} +#endif #endif /* _SC_SCI_H */ -- 2.7.4