RE: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY

Hi, Dmitry

Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for
KEYBOARD_IMX_SC_KEY

On Sat, Mar 07, 2020 at 12:18:38AM +0000, Anson Huang wrote:

quoted

Hi, Dmitry

quoted

Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support
for KEYBOARD_IMX_SC_KEY

On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov
[off-list ref] wrote:

quoted

On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote:

quoted

Add COMPILE_TEST support to i.MX SC keyboard driver for better
compile testing coverage.

Signed-off-by: Anson Huang <redacted>

Applied, thank you.

Actually, not:

ERROR: "imx_scu_irq_register_notifier"
[drivers/input/keyboard/imx_sc_key.ko] undefined!
ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko]
undefined!
ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko]
undefined!
ERROR: "imx_scu_irq_unregister_notifier"
[drivers/input/keyboard/imx_sc_key.ko] undefined!
ERROR: "imx_scu_irq_group_enable"
[drivers/input/keyboard/imx_sc_key.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1282: modules] Error 2

If you want to enable compile test coverage you need to provide
stubs for the above functions.

These i.MX SCU drivers depends on IMX_SCU, I already add the
COMPILE_TEST to IMX_SCU driver as well, that is why I put these patches in

a patch series.

Adding "|| COMPILE_TEST" you are removing hard dependency on IMX_SCU,
which as you can see can result in broken build.

quoted

Maybe
I can add stubs as well to make sure build passed even when IMX_SCU is

NOT compiled?

quoted

Will send V2 to add stubs, it makes more sense.

It is up to you whether you make IMX_SCU buildable with COMPILE_TEST and
leave the sub-driver as is, or add the stubs and make sub-drivers buildable
even without IMX_SCU being present.

Thank you, I already added COMPILE_TEST to IMX_SCU driver, and I will also add
stubs for those APIs in V2.

Thanks,
Anson