RE: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY
From: Anson Huang <hidden>
Date: 2020-03-07 00:18:45
Also in:
linux-arm-kernel, linux-pm, linux-rtc, linux-watchdog, lkml
Hi, Dmitry
Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov [off-list ref] wrote:quoted
On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote:quoted
Add COMPILE_TEST support to i.MX SC keyboard driver for better compile testing coverage. Signed-off-by: Anson Huang <redacted>Applied, thank you.Actually, not: ERROR: "imx_scu_irq_register_notifier" [drivers/input/keyboard/imx_sc_key.ko] undefined! ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko] undefined! ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko] undefined! ERROR: "imx_scu_irq_unregister_notifier" [drivers/input/keyboard/imx_sc_key.ko] undefined! ERROR: "imx_scu_irq_group_enable" [drivers/input/keyboard/imx_sc_key.ko] undefined! make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 make: *** [Makefile:1282: modules] Error 2 If you want to enable compile test coverage you need to provide stubs for the above functions.
These i.MX SCU drivers depends on IMX_SCU, I already add the COMPILE_TEST to IMX_SCU driver as well, that is why I put these patches in a patch series. Maybe I can add stubs as well to make sure build passed even when IMX_SCU is NOT compiled? Will send V2 to add stubs, it makes more sense. Thanks, Anson