Re: [PATCH v6 3/5] arm64: dts: qcom: Add Lenovo Miix 630
From: Rob Clark <hidden>
Date: 2019-06-14 13:44:49
Also in:
linux-arm-msm, linux-devicetree, lkml
On Thu, Jun 13, 2019 at 10:17 AM Jeffrey Hugo [off-list ref] wrote:
This adds the initial DT for the Lenovo Miix 630 laptop. Supported functionality includes USB (host), microSD-card, keyboard, and trackpad. Signed-off-by: Jeffrey Hugo <redacted> ---
[snip]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts new file mode 100644 index 000000000000..407c6a32911c --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts@@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2019, Jeffrey Hugo. All rights reserved. */ + +/dts-v1/; + +#include "msm8998-clamshell.dtsi" + +/ { + model = "Lenovo Miix 630"; + compatible = "lenovo,miix-630", "qcom,msm8998"; +};
So, I'm not sure if there is some precedent for this (but maybe we haven't really had this problem before).. but as I mentioned on #arch64-laptops, I think we should put vendor/product/board-id strings from SMBIOS table in the dts files. That could be used by grub to find the correct dtb file to load in a generic way. (Ie, look for a match of all three strings, and maybe fallback to a match on just vendor+product??) At any rate, how the strings are used can be refined later. But I think we should include the strings from the beginning for anything that is booting via UEFI. It's perhaps more useful than the compatible string. BR, -R