Thread (27 messages) 27 messages, 6 authors, 2019-04-04

Re: [RESEND PATCH v6 09/11] leds: max77650: add LEDs support

From: Pavel Machek <hidden>
Date: 2019-03-22 09:21:30
Also in: linux-devicetree, linux-gpio, linux-leds, linux-pm, lkml

On Mon 2019-03-18 18:42:26, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <redacted>

This adds basic support for LEDs for the max77650 PMIC. The device has
three current sinks for driving LEDs.

Signed-off-by: Bartosz Golaszewski <redacted>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Pavel Machek <redacted>
+		label = of_get_property(child, "label", NULL);
+		if (!label) {
+			led->cdev.name = "max77650::";
+		} else {
+			led->cdev.name = devm_kasprintf(dev, GFP_KERNEL,
+							"max77650:%s", label);
+			if (!led->cdev.name)
+				return -ENOMEM;
+		}
I'd rather not have the "max77650:" prefix in the LED name (as it is
useless).

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help